Modernizing PurpleChatConversation.

Review Request #583 — Created March 26, 2021 and submitted

grim
pidgin/pidgin
default
f06ea8fa57fc
pidgin
I wasn't able to do everything as PurpleConversation still isn't declared with
G_DECLARE_DERIVABLE_TYPE.

Compiled ran locally with both xmpp mucs and irc channels.

Description From Last Updated

PurpleChatUser

QuLogicQuLogic

@user or @message

QuLogicQuLogic

Can drop this comment now, I think.

QuLogicQuLogic

its

QuLogicQuLogic

Maybe this should be PROP_CHAT_ID?

QuLogicQuLogic

This seems new; is it really needed right now?

QuLogicQuLogic

Why not set priv->updated directly like in purple_chat_conversation_ignore?

QuLogicQuLogic

You deleted the setting of the new values?

QuLogicQuLogic

I don't understand why users and flags needed an extra iteration variable (ul and fl) while extra_msgs didn't.

QuLogicQuLogic

Can remove the extra space.

QuLogicQuLogic

gchar?

QuLogicQuLogic

Missed that this should be 'referred' earlier.

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/purplechatconversation.h (Diff revision 1)
     
     

    PurpleChatUser

  3. libpurple/purplechatconversation.h (Diff revision 1)
     
     

    @user or @message

  4. libpurple/purplechatconversation.c (Diff revision 1)
     
     

    Can drop this comment now, I think.

  5. libpurple/purplechatconversation.c (Diff revision 1)
     
     

    Maybe this should be PROP_CHAT_ID?

  6. libpurple/purplechatconversation.c (Diff revision 1)
     
     
     
     
     
     
     

    This seems new; is it really needed right now?

    1. The old code checked if purple_account_get_connection() was NULL to do the same check.

    2. But those are not the same thing, as the account would have a connection while connecting. Which I think is subtly different enough that it should not go into a refactoring change like this.

  7. libpurple/purplechatconversation.c (Diff revision 1)
     
     
     

    Why not set priv->updated directly like in purple_chat_conversation_ignore?

  8. libpurple/purplechatconversation.c (Diff revision 1)
     
     
     

    You deleted the setting of the new values?

  9. libpurple/purplechatconversation.c (Diff revision 1)
     
     
     
     
     
     

    I don't understand why users and flags needed an extra iteration variable (ul and fl) while extra_msgs didn't.

  10. libpurple/purplechatconversation.c (Diff revision 1)
     
     

    Can remove the extra space.

  11. libpurple/purplechatconversation.c (Diff revision 1)
     
     
  12. 
      
grim
QuLogic
  1. 
      
  2. libpurple/purplechatconversation.h (Diff revision 2)
     
     

    Missed that this should be 'referred' earlier.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...