Summary

Add configuration directory path to help window

Review Request #577 — Created March 19, 2021 and submitted March 30, 2021, 4:17 a.m.

Information

Owner

tanweerali908@gmail.com

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17504

Depends On

Commit

f1e3e309d993

Reviewers

Groups

pidgin

People

Description

Add Runtime Directories Path section to Build Information tab in Help->About window.

Testing Done

Compile and run

Changed

Issues

Description	From	Last Updated
Awesome work! However, I'm going to ask you to go one step further. I thought I had put this in …	grim	March 27, 2021, 11:27 p.m.
These paths should be column 1 and column 0 should be the text from the table I made in the …	grim	March 27, 2021, 11:27 p.m.
This looks like there's extra tabs in the alignment where there should be spaces?	grim	March 27, 2021, 11:27 p.m.
This string should be marked for translation.	QuLogic	March 29, 2021, 9:41 a.m.
Mark for translation.	QuLogic	March 29, 2021, 9:41 a.m.
Mark for translation.	QuLogic	March 29, 2021, 9:41 a.m.

Description:

~		Add `Configuration Directory Path` section to `Help->About` window in `Build Information` tab.
	~	Add `Configuration Directory Path` section to `Build Information` tab in `Help->About` window.

Show all issues

Awesome work! However, I'm going to ask you to go one step further. I thought I had put this in the ticket, but apparently I didn't, sorry about that.
However, can you change the title to Runtime Directories and add the following items similar to the other settings where each row has a title and a value.
Title         | function to call

--------------+--------------------

Cache         | purple_cache_dir()

Configuration | purple_config_dir()

Data          | purple_data_dir()

tanweerali908@gmail.com March 23, 2021, 4:18 p.m.
```
sure
```

Change Summary:

Replace Configuration Directory Path name of section to Runtime Directories
Add Cache directory path in that section
Add Data directory path in that section

Commit:

-	ca3fc58196f2
+	a822e15cd910

Diff:

Revision 2 (+37)

Show changes

pidgin/pidginabout.c

Testing Done:

		Compile and run

~
	~

pidgin/pidginabout.c (Diff revision 2)

Show all issues

These paths should be column 1 and column 0 should be the text from the table I made in the general comment but marked for translations.

tanweerali908@gmail.com March 26, 2021, 8:39 a.m.
```
ohh ok, I will fix it now.
```

pidgin/pidginabout.c (Diff revision 2)

Show all issues

This looks like there's extra tabs in the alignment where there should be spaces?

tanweerali908@gmail.com March 26, 2021, 9:02 a.m.

yeah now I saw that there are extra tabs in some lines. I will fix that too now

Change Summary:

Seperate columns
Fix Indentation

Commit:

-	a822e15cd910
+	a0a1a0a3f5bd

Diff:

Revision 3 (+40)

Show changes

pidgin/pidginabout.c

Testing Done:

		Compile and run

~
	~

Description:

~		Add `Configuration Directory Path` section to `Build Information` tab in `Help->About` window.
	~	Add `Runtime Directories Path` section to `Build Information` tab in `Help->About` window.

pidgin/pidginabout.c (Diff revision 3)

Show all issues

This string should be marked for translation.

pidgin/pidginabout.c (Diff revision 3)
Show all issues
```
Mark for translation.
```
pidgin/pidginabout.c (Diff revision 3)
Show all issues
```
Mark for translation.
```

Change Summary:

Mark strings for translation

Commit:

-	a0a1a0a3f5bd
+	f1e3e309d993

Diff:

Revision 4 (+40)

Show changes

pidgin/pidginabout.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Add configuration directory path to help window

Information

Reviewers

Description:

Change Summary:

Commit:

Diff:

Testing Done:

Change Summary:

Commit:

Diff:

Testing Done:

Description:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)