Refresh all of the ui files

Review Request #559 — Created March 6, 2021 and submitted

Information

pidgin/pidgin
default
14d3934161ec

Reviewers

  • Resaved everything with Glade 3.38 which changes all of the properties from
    using _'s to using -'s.
  • Make sure everything has the license information, including the menu files
    that Glade doesn't handle directly.
  • Make sure that all of our ui files are requiring Gtk 3.22 as that is our
    minimum and many of them were set to 3.20 which was making Glade angry.
  • Change the margin-left to margin-start in xfer.ui

Glade is doing some weird stuff though that we'll need to watch in the future. Namely the format view isn't showing up as an internal client in TalkatuEditor for some reason and Glade removed the property from the Invisible GtkTextTag.

Compiled and ran locally.

Description From Last Updated

Revert?

QuLogicQuLogic

This should be activatable, no?

QuLogicQuLogic

The default is unset, and this tag is applied in the middle of text that is tagged as invisible. So …

QuLogicQuLogic

the invisible and invisible-set properties

QuLogicQuLogic

I thought it was TRUE for both?

QuLogicQuLogic
QuLogic
  1. 
      
  2. pidgin/resources/Avatar/avatar.ui (Diff revision 1)
     
     
     

    Revert?

    1. Unfortunately no... In Glade we just select the license and it dumps in the text. Unfortunately that text includes the physical address.

  3. pidgin/resources/Debug/debug.ui (Diff revision 1)
     
     
     

    This should be activatable, no?

    1. So activatable defaults to TRUE so glade just removed it. https://developer.gnome.org/gtk3/stable/GtkEntry.html#GtkEntry--primary-icon-activatable

    2. Maybe, but without activatable, the button does not work.

  4. 
      
grim
QuLogic
  1. 
      
  2. pidgin/resources/Debug/debug.ui (Diff revision 2)
     
     
     
     

    The default is unset, and this tag is applied in the middle of text that is tagged as invisible. So it must be set to visible in order to undo that.

  3. pidgin/resources/Debug/debug.ui (Diff revision 2)
     
     

    I thought it was TRUE for both?

    1. I thought it was, but apparently I confused myself. I just verified against gtk-doc but I can try the inspector as well if you like.

    2. Was the documentation wrong for some version then? It definitely says TRUE for both.

    3. Looking at the code it's for sure true, but if you remove them, the inspector says both of them are FALSE. What's causing it, I'm not sure, but that's what's happening.

  4. 
      
grim
grim
QuLogic
  1. 
      
  2. pidgin/resources/Debug/debug.ui (Diff revisions 2 - 3)
     
     

    the invisible and invisible-set properties

  3. 
      
grim
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...