Summary

Turn on -fanalyzer if available and fix the issues it found

Review Request #3542 — Created Sept. 27, 2024 and submitted Sept. 27, 2024, 1:21 a.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Turn on -fanalyzer if available and fix the issues it found

Testing Done

Verified the findings were gone and called in the turtles for good measure.

Commits

Summary	ID
Turn on -fanalyzer if available and fix the issues it found	8e41956acc3e8a005cdb883537e2e0b83b972c79

Issues

Description	From	Last Updated
Does it work if you put this in gplugin_native_loader_lookup_symbol? Then it would technically be checking all symbols (even if the …	QuLogic	Sept. 27, 2024, 1:14 a.m.
Note compiler is already fetched on line 88 (though that's after this line.)	QuLogic	Sept. 27, 2024, 1:14 a.m.

gplugin/gplugin-native-loader.c (Diff revision 1)

The issue has been dropped. Show all issues

Does it work if you put this in gplugin_native_loader_lookup_symbol? Then it would technically be checking all symbols (even if the analyzer doesn't see it.)

meson.build (Diff revision 1)

The issue has been resolved. Show all issues

Note compiler is already fetched on line 88 (though that's after this line.)

grim Sept. 27, 2024, 1:11 a.m.

It is apparently not that smart as I still got the warning.

grim Sept. 27, 2024, 1:14 a.m.

whoops, that should have been on the other message...

Change Summary:

rebased and consolidated the compiler argument checks in meson.build.

Commits:

	Summary	ID
	Turn on -fanalyzer if available and fix the issues it found	703d5345315c93cc7e87bd3ee005f7a6a3415e11
	Turn on -fanalyzer if available and fix the issues it found	8e41956acc3e8a005cdb883537e2e0b83b972c79

Diff:

Revision 2 (+30 -6)

Show changes

	meson.build
	gplugin/gplugin-native-loader.c
	gplugin-gtk4-viewer/gplugin-gtk-viewer.c

Ship it!

```
Ship It!
```

Status:: Completed