Summary

IRCv3: Fix a bug where part messages were not being parsed correctly

Review Request #3538 — Created Sept. 27, 2024 and submitted Sept. 27, 2024, 6:50 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

IRCv3: Fix a bug where part messages were not being parsed correctly

Testing Done

Verified this with an in progress review request to add event messages for joins/parts.

Commits

Summary	ID
IRCv3: Fix a bug where part messages were not being parsed correctly	ac26a1e11a507b9359717a6b7de3d9cd3056ad95

Issues

Description	From	Last Updated
I guess there is a second call to this on line 105, so the variable could be kept, but I …	QuLogic	Sept. 27, 2024, 6:16 a.m.
Probably don't need to move this?	QuLogic	Sept. 27, 2024, 6:49 a.m.

protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)

The issue has been resolved. Show all issues

I guess there is a second call to this on line 105, so the variable could be kept, but I could go either way.

Change Summary:

rebased and use a variable for the length again.

Commits:

	Summary	ID
	IRCv3: Fix a bug where part messages were not being parsed correctly	642712a2dddc34089e5b30f077894a0e218d48e7
	IRCv3: Fix a bug where part messages were not being parsed correctly	6609c037dbbbe126d5dd4ef71e097b4345879ed7

Diff:

Ship it!

protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 2)

The issue has been resolved. Show all issues

Probably don't need to move this?

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	IRCv3: Fix a bug where part messages were not being parsed correctly	6609c037dbbbe126d5dd4ef71e097b4345879ed7
	IRCv3: Fix a bug where part messages were not being parsed correctly	ac26a1e11a507b9359717a6b7de3d9cd3056ad95

Diff: