Create Pidgin.TypingLabel

Review Request #3490 — Created Sept. 17, 2024 and submitted

Information

pidgin/pidgin
default

Reviewers

This use Purple.ConversationMembers:active-typers to display a label of who is
currently typing.

Connected to a local ergo and verified that we say notification from a senpai client.

Summary ID
Create Pidgin.TypingLabel
This use Purple.ConversationMembers:active-typers to display a label of who is currently typing.
197ae25852c8d0047c7256805b477a94da7b6ebc
Description From Last Updated

Can move in the next if too?

QuLogicQuLogic

What owns filtered? Seems like it leaks out of this if.

QuLogicQuLogic

filter is not taken by this function now, unlike the _new, and is probably leaking.

QuLogicQuLogic

Is this going to be used for something later? It doesn't appear to be called.

QuLogicQuLogic

Maybe ellipsize=end?

QuLogicQuLogic
QuLogic
  1. Ship It!
  2. pidgin/pidgintypinglabel.c (Diff revision 1)
     
     
    Show all issues

    Can move in the next if too?

  3. pidgin/pidgintypinglabel.c (Diff revision 1)
     
     
    Show all issues

    What owns filtered? Seems like it leaks out of this if.

  4. pidgin/pidgintypinglabel.c (Diff revision 1)
     
     

    This isn't necessarily the greatest for translation, but I'm not sure there's much of a better way when it's not single/plural.

    1. yeah I know, and even then, how do you build that code. I went back and forth on this for awhile and am open to any suggestions.

  5. pidgin/pidgintypinglabel.h (Diff revision 1)
     
     
    Show all issues

    Is this going to be used for something later? It doesn't appear to be called.

    1. Well it's a readable property but aside from that I don't know. I think I was originally thinking of using it with bindings in the ui file to get the model, but we've kind of worked around that now.

  6. pidgin/resources/typinglabel.ui (Diff revision 1)
     
     
     
     
     
     
    Show all issues

    Maybe ellipsize=end?

  7. 
      
grim
QuLogic
  1. 
      
  2. pidgin/pidgintypinglabel.c (Diff revisions 1 - 2)
     
     
     
    Show all issues

    filter is not taken by this function now, unlike the _new, and is probably leaking.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed