Summary

Create Pidgin.TypingLabel

Review Request #3490 — Created Sept. 16, 2024 and submitted Sept. 17, 2024, 1:40 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17896

Depends On

Reviewers

Groups

pidgin

People

Description

This use Purple.ConversationMembers:active-typers to display a label of who is
currently typing.

Testing Done

Connected to a local ergo and verified that we say notification from a senpai client.

Commits

Summary	ID
Create Pidgin.TypingLabel This use Purple.ConversationMembers:active-typers to display a label of who is currently typing.	197ae25852c8d0047c7256805b477a94da7b6ebc

Issues

Description	From	Last Updated
Can move in the next if too?	QuLogic	Sept. 17, 2024, 1:33 a.m.
What owns filtered? Seems like it leaks out of this if.	QuLogic	Sept. 17, 2024, 1:35 a.m.
filter is not taken by this function now, unlike the _new, and is probably leaking.	QuLogic	Sept. 17, 2024, 1:38 a.m.
Is this going to be used for something later? It doesn't appear to be called.	QuLogic	Sept. 17, 2024, 1:35 a.m.
Maybe ellipsize=end?	QuLogic	Sept. 17, 2024, 1:37 a.m.

Ship it!

```
Ship It!
```
pidgin/pidgintypinglabel.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Can move in the next if too?
```
pidgin/pidgintypinglabel.c (Diff revision 1)
The issue has been resolved. Show all issues
```
What owns filtered? Seems like it leaks out of this if.
```

pidgin/pidgintypinglabel.c (Diff revision 1)

This isn't necessarily the greatest for translation, but I'm not sure there's much of a better way when it's not single/plural.

grim Sept. 17, 2024, 1:11 a.m.

yeah I know, and even then, how do you build that code. I went back and forth on this for awhile and am open to any suggestions.

pidgin/pidgintypinglabel.h (Diff revision 1)

The issue has been dropped. Show all issues

Is this going to be used for something later? It doesn't appear to be called.

grim Sept. 17, 2024, 1:11 a.m.

Well it's a readable property but aside from that I don't know. I think I was originally thinking of using it with bindings in the ui file to get the model, but we've kind of worked around that now.

pidgin/resources/typinglabel.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Maybe ellipsize=end?
```

Change Summary:

Rebase and address issues.

Commits:

	Summary	ID
	Create Pidgin.TypingLabel This use Purple.ConversationMembers:active-typers to display a label of who is currently typing.	f0bacabb4519ba20c80ad06065d4c92cb72f5b0f
	Create Pidgin.TypingLabel This use Purple.ConversationMembers:active-typers to display a label of who is currently typing.	aa78175d179851904654ea56c4e36da8b845ffa9

Diff:

Revision 2 (+858 -2)

Show changes

	pidgin/meson.build
	pidgin/pidginconversation.h
	pidgin/pidgintypinglabel.h
	pidgin/pidgintypinglabel.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/typinglabel.ui
	pidgin/resources/Conversations/conversation.ui

pidgin/pidgintypinglabel.c (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

filter is not taken by this function now, unlike the _new, and is probably leaking.

Change Summary:

unref the filter.

Commits:

	Summary	ID
	Create Pidgin.TypingLabel This use Purple.ConversationMembers:active-typers to display a label of who is currently typing.	aa78175d179851904654ea56c4e36da8b845ffa9
	Create Pidgin.TypingLabel This use Purple.ConversationMembers:active-typers to display a label of who is currently typing.	197ae25852c8d0047c7256805b477a94da7b6ebc

Diff:

Revision 3 (+860 -2)

Show changes

	pidgin/meson.build
	pidgin/pidginconversation.h
	pidgin/pidgintypinglabel.h
	pidgin/pidgintypinglabel.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/typinglabel.ui
	pidgin/resources/Conversations/conversation.ui

Ship it!

```
Ship It!
```

Status:: Completed