Summary

Update Purple.NotificationAuthorizationRequest to take an id and auto populate account

Review Request #3475 — Created Sept. 10, 2024 and submitted Sept. 10, 2024, 6:31 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17939

Depends On

~~3474~~

Reviewers

Groups

pidgin

People

Description

This also removed the duplication in purplenotification.c.

Testing Done

Ran the unit tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Update Purple.NotificationAuthorizationRequest to take an id and auto populate account This also removed the duplication in purplenotification.c.	10e25eb8fdc02407c491c11e56444e217b07ea2d

Issues

Description	From	Last Updated
So this one already sets account in a different way than the other RR. Though I suppose it should move …	QuLogic	Sept. 10, 2024, 6:21 a.m.

Change Summary:

Add a default icon

Commits:

	Summary	ID
	Update Purple.NotificationAuthorizationRequest to take an id and auto populate account This also removed the duplication in purplenotification.c.	b4a9780436c8a38d087ac8d011cca42a53f7629b
	Update Purple.NotificationAuthorizationRequest to take an id and auto populate account This also removed the duplication in purplenotification.c.	fd8cc27c5715132c9793ff63e177640569292587

Diff:

Revision 2 (+120 -76)

Show changes

	libpurple/purplenotification.h
	libpurple/purplenotification.c
	libpurple/purplenotificationauthorizationrequest.h
	libpurple/purplenotificationauthorizationrequest.c
	libpurple/tests/test_notification_authorization_request.c

libpurple/purplenotificationauthorizationrequest.c (Diff revision 2)

The issue has been resolved. Show all issues

So this one already sets account in a different way than the other RR. Though I suppose it should move as well in case anyone calls g_object_new directly (like the tests).

Change Summary:

rebase and fix the way we set the account

Commits:

	Summary	ID
	Update Purple.NotificationAuthorizationRequest to take an id and auto populate account This also removed the duplication in purplenotification.c.	fd8cc27c5715132c9793ff63e177640569292587
	Update Purple.NotificationAuthorizationRequest to take an id and auto populate account This also removed the duplication in purplenotification.c.	10e25eb8fdc02407c491c11e56444e217b07ea2d

Diff:

Revision 3 (+148 -92)

Show changes

	libpurple/purplenotification.h
	libpurple/purplenotification.c
	libpurple/purplenotificationauthorizationrequest.h
	libpurple/purplenotificationauthorizationrequest.c
	libpurple/tests/test_notification_authorization_request.c

Ship it!

```
Ship It!
```

Status:: Completed