Summary

IRCv3: Handle RPL_NAMREPLY

Review Request #3472 — Created Sept. 6, 2024 and submitted Sept. 10, 2024, 5:26 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Right now this just updates Conversation:members but doesn't handle channel
membership prefixes yet as I wanted to keep this review request simple.

Testing Done

Connected to my local ergo server and verified that the members list was populated.

Commits

Summary	ID
IRCv3: Handle RPL_NAMREPLY Right now this just updates Conversation:members but doesn't handle channel membership prefixes yet as I wanted to keep this review request simple.	5f6a7e634a7aa8bc8ade48220453d69c86e88392

Issues

Description	From	Last Updated
the last parameter on space?	QuLogic	Sept. 10, 2024, 5:23 a.m.

protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)
The issue has been resolved. Show all issues
```
the last parameter on space?
```

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	IRCv3: Handle RPL_NAMREPLY Right now this just updates Conversation:members but doesn't handle channel membership prefixes yet as I wanted to keep this review request simple.	b2fec35989e86c0bfcb5f6d0b4fe922dd529e764
	IRCv3: Handle RPL_NAMREPLY Right now this just updates Conversation:members but doesn't handle channel membership prefixes yet as I wanted to keep this review request simple.	5f6a7e634a7aa8bc8ade48220453d69c86e88392

Diff:

	im.pidgin.Pidgin3.yml
	protocols/ircv3/meson.build
	protocols/ircv3/purpleircv3connection.c
	protocols/ircv3/purpleircv3messagehandlers.h
	protocols/ircv3/purpleircv3messagehandlers.c
	subprojects/ibis.wrap

Ship it!