Summary

Add BirbActionMenu

Review Request #2902 — Created Dec. 30, 2023 and submitted Jan. 12, 2024, 1:50 a.m.

Information

Owner

grim

Repository

birb/birb

Branch

default

Bugs

Depends On

Blocks

2838, 2837

Reviewers

Groups

pidgin

People

Description

This class makes it easy to populate a menu via a signal emission.

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Add BirbActionMenu This class makes it easy to populate a menu via a signal emission.	0585c9cd3136a2fa67888c5ccabffecded2c9c4d

Issues

Description	From	Last Updated
Hmm, GPL or LGPL? The repo doesn't have a license file right now, and I think I see both headers.	QuLogic	Jan. 12, 2024, 1:46 a.m.
s/does/did/	QuLogic	Jan. 12, 2024, 1:46 a.m.
Do we want to allow NULL for group to remove the prefix? (I vaguely remember some GTK API like that.)	QuLogic	Jan. 12, 2024, 1:46 a.m.

birb/birbactionmenu.h (Diff revision 1)

The issue has been dropped. Show all issues

Hmm, GPL or LGPL? The repo doesn't have a license file right now, and I think I see both headers.

grim Jan. 12, 2024, 1:31 a.m.

The license should match whatever libpurple is, which is weird if they're different...

grim Jan. 12, 2024, 1:37 a.m.

There's some inconsistencies with libpurple's licensing, but it's 202 GPL's to 28 LGPL's, so we should go with GPL.

birb/birbactionmenu.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/does/did/
```

birb/birbactionmenu.c (Diff revision 1)

The issue has been dropped. Show all issues

Do we want to allow NULL for group to remove the prefix? (I vaguely remember some GTK API like that.)

grim Jan. 12, 2024, 1:31 a.m.

If we're going to do this, lets do a separate function as g_hash_table_remove returns TRUE if it was found, but here we're returning TRUE if it didn't exist.
At any rate, I don't think we need to worry about this yet, but maybe?

Change Summary:

Fix the typo

Commits:

	Summary	ID
	Add BirbActionMenu This class makes it easy to populate a menu via a signal emission.	2bb4b47e3018246d0c7d56614b6512c330c09b17
	Add BirbActionMenu This class makes it easy to populate a menu via a signal emission.	0585c9cd3136a2fa67888c5ccabffecded2c9c4d

Diff:

Revision 2 (+706)

Show changes

	birb/birbactionmenu.h
	birb/birbactionmenu.c
	birb/meson.build
	birb/tests/meson.build
	birb/tests/test_action_menu.c

Ship it!

```
Ship It!
```

Status:: Completed