Don't use the Real name as a candidate for the SASL username in IRC

Review Request #2535 — Created July 28, 2023 and submitted

Information

pidgin/pidgin
release-2.x.y

Reviewers

The real name field is free form text which means it can contain characters
that aren't allowed in irc/sasl account names. So if a user has a real name set
but not a sasl login name, they get hard to trouble shoot authentication
failures. So to avoid all that, we're removing real name as an option and just
allowing the "newer" field and falling back to the username if that field isn't
set.

Compiled

Summary ID
Don't use the Real name as a candidate for the SASL username in IRC
The real name field is free form text which means it can contain characters that aren't allowed in irc/sasl account names. So if a user has a real name set but not a sasl login name, they get hard to trouble shoot authentication failures. So to avoid all that, we're removing real name as an option and just allowing the "newer" field and falling back to the username if that field isn't set.
21bc62dc516ed1e0ae66918ee91dfae8d5957f46
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed