Clean up Finch preferences page

 






 

 


  Review Request #2416
  —
  Created April 3, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  QuLogic
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
Instead of mixing two strings into a GList, use a PurpleKeyValuePair.

Use struct initializers and G_N_ELEMENTS.

Rename lv to choices for clarity.

Change from PurpleRequestFieldList to PurpleRequestFieldChoice as we don't need multiple selection.

 








  


 
 

  
Opened Finch, opened Preferences, saved them, and exited Finch. Re-opened Prefs and confirmed they were saved and as expected.

 







 









 





  








 




 







   

    
    

    

    


    

      
Commits

      

        
      

    


    


      
Files