Cleanup request field files

 






 

 


  Review Request #2342
  —
  Created March 11, 2023 and submitted 

 




















 

  

   Information

  





 
 

  QuLogic
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  2340
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
A variety of small followups to splitting the request objects into separate files:
* Make PurpleRequestField into an abstract type and drop the field type enum.
* Add request files to GObject introspection.
* Replace purple_debug with GLib logging.
* Remove extra #include where possible.
* Remove most early typedef which were there for #include loops.
* Put G_DEFINE_TYPE in a consistent place.
* Add Since tags to objects since they are new (but not the functions), and also to all of PurpleRequestPage/PurpleRequestGroup which were fully renamed.
* Use website for GNU reference in license header.
* Clean up old entries in ChangeLog.API.

 








  


 
 

  
Compiled, then checked Class Hierarchy in docs and confirmed that the structs were now there.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     
Cleanup request field files


    		
    775360af83f5c7b348277852faece1a86c8a5de1

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Our license headers for libpurple have another difference besides just the fsf's website. /* * Purple - Internet Messaging Library …

      		
      
       grimgrim
      
      
       
      
     




     

      
       
       
Do we gain anything by having this abstract? The only reason I can think of to make this not abstract …

      		
      
       grimgrim
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




grim




   

   







  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Our license headers for libpurple have another difference besides just the fsf's website.
    

    

    /*                     
 * Purple - Internet Messaging Library
 * Copyright (C) Pidgin Developers <devel@pidgin.im>
 *

    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 















  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      libpurple/purplerequestfield.c
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Do we gain anything by having this abstract?
    

    The only reason I can think of to make this not abstract is it'd make writing unit tests to make sure properties are okay difficult as you'd have to subclass.
    

    Also I'm not saying we would leave the constuctor around as it wouldn't be needed.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      We can use a PurpleRequestFieldLabel for tests as it's basically a concrete version without any additional functionality.
      

      In fact, it's so much the same that it could not exist and be what the base class does, but I think that would make subclass testing more complicated.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Ah that makes a lot of sense, thanks for explaining!
      
 
      

      3. 


 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




QuLogic




   

   

  

 



 















 





 

  

   




grim




   

   







  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    




    
    Awesome work, thanks!!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...