IRCv3: Set the SASL login name to the current nick if not set during connection

 






 

 


  Review Request #2329
  —
  Created March 8, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
This _should_ help users make sure they authenticate as the correct user. They
are still able to manually specify a SASL Login Name, but if it isn't set when
a connection is attempted, it will be set to the nick defined on the account.

This should also fix the scenario where a user is adding the account to Pidgin
but already has the same account connected because the login name will be the
nick they entered not the one that's chosen if there's a nick collision.

 








  


 
 

  
Connected an IRCv3 account with the SASL Login Name unset and verified it was set after connecting. Then set the SASL Login Name to something else, attempted connection, verified a SASL failure and verified that the SASL Login Name changed persisted.

 







 









 





  








 




 







   

    
    

    

    


    

      
Commits

      

        
      

    


    


      
Files


      

       
      

    

    

   

  

 





    


    

    





     
    
    
    
   
    
  
    
  
    
   
   Loading...