Remove Cyrus SASL from XMPP

 






 

 


  Review Request #2295
  —
  Created Feb. 26, 2023 and submitted 

 




















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
This will eventually be replaced by Hasl, but XMPP has it's own built-in SASL
mechanisms as well as Cyrus, so removing Cyrus first is just the first step.

 








  


 
 

  
Connected an XMPP account, sent direct messages from both sides, and joined a muc and sent messages from both sides as well.

Also ran the unit tests.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Remove Cyrus SASL from XMPP
      
This will eventually be replaced by Hasl, but XMPP has it's own built-in SASL
mechanisms as well as Cyrus, so removing Cyrus first is just the first step.

     


    		
    2df95c047e8074e74c93d8bf74cb4208d15e3286

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Did you figure out if XMPP needs to support any SASL mechanisms that provide a security layer (for HASL purposes …

      		
      
       QuLogicQuLogic
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




QuLogic




   

   









  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      libpurple/protocols/jabber/jabber.c
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Did you figure out if XMPP needs to support any SASL mechanisms that provide a security layer (for HASL purposes later)?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      The scram stuff does have channel bind for SCRAM-*-*-PLUS but that was done outside of cyrus and can be found in auth_scram.c. So we'll most likely readjust this stuff as necessary if/when we want to implement those mechanisms. That said, I haven't seen many in the wild but I also haven't looked too hard.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      There's a #define CHANNEL_BINDING, but it appears that's not actually fully implemented. I'm not sure that channel binding is the same the security layer stuff, but really the only layer I found was DIGEST-MD5 and I'm not sure anyone should be using that these days.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      That was basically my findings as well.
      
 
      

      4. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...