Summary

Make the DisplayWindow use a GtkListView

Review Request #2227 — Created Feb. 7, 2023 and submitted Feb. 10, 2023, 4:58 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17752

Depends On

Reviewers

Groups

pidgin

People

Description

The traditional pattern of using a TreeView and Notebook/stack has been
removed. This now use a ListView with a model that contains the child widgets,
and an AdwBin where we swap the children in and out.

I didn't implement everything, as now that this window is a bit more mixed
content, things aren't as clear cut. I left some TODO's in the code describing
these scenarios.

Testing Done

Tested opening and closing chats in the ui. Verified the keybinds work for navigating everything thing.

Commits

Summary	ID
Make the DisplayWindow use a GtkListView The traditional pattern of using a TreeView and Notebook/stack has been removed. This now use a ListView with a model that contains the child widgets, and an AdwBin where we swap the children in and out. I didn't implement everything, as now that this window is a bit more mixed content, things aren't as clear cut. I left some TODO's in the code describing these scenarios.	392840f0156459ea2af8418412fdb26b620a1214

Summary

Make the DisplayWindow use a GtkListView

The traditional pattern of using a TreeView and Notebook/stack has been removed. This now use a ListView with a model that contains the child widgets, and an AdwBin where we swap the children in and out. I didn't implement everything, as now that this window is a bit more mixed content, things aren't as clear cut. I left some TODO's in the code describing these scenarios.

392840f0156459ea2af8418412fdb26b620a1214

Issues

Description	From	Last Updated
s/that represents/that's	ivanhoe	Feb. 8, 2023, 6:57 a.m.
I guess one "widget" is enough?	ivanhoe	Feb. 8, 2023, 6:57 a.m.
s/the are/there are	ivanhoe	Feb. 8, 2023, 6:57 a.m.

pidgin/pidgindisplayitem.h (Diff revision 1)
Show all issues
```
s/that represents/that's
```
pidgin/pidgindisplayitem.h (Diff revision 1)
Show all issues
```
I guess one "widget" is enough?
```
1. grim Feb. 8, 2023, 12:49 a.m.
  who's to say?
pidgin/pidgindisplayitem.h (Diff revision 1)
Show all issues
```
s/the are/there are
```

Change Summary:

Fix typos

Commits:

	Summary	ID
	Make the DisplayWindow use a GtkListView The traditional pattern of using a TreeView and Notebook/stack has been removed. This now use a ListView with a model that contains the child widgets, and an AdwBin where we swap the children in and out. I didn't implement everything, as now that this window is a bit more mixed content, things aren't as clear cut. I left some TODO's in the code describing these scenarios.	1c836f51daa7fff63c14d483643aef7e149d343a
	Make the DisplayWindow use a GtkListView The traditional pattern of using a TreeView and Notebook/stack has been removed. This now use a ListView with a model that contains the child widgets, and an AdwBin where we swap the children in and out. I didn't implement everything, as now that this window is a bit more mixed content, things aren't as clear cut. I left some TODO's in the code describing these scenarios.	8a2284307f2bb770c8322b7f828ced5c2e352fc5

Diff:

Revision 2 (+1908 -786)

Show changes

	pidgin/meson.build
	pidgin/pidgindisplayitem.h
	pidgin/pidgindisplayitem.c
	pidgin/pidgindisplaywindow.c
	pidgin/resources/Display/window.ui

pidgin/pidgindisplaywindow.c (Diff revision 2)

Who takes care of freeing that tree_model?

pidgin/pidgindisplaywindow.c (Diff revision 2)
```
Who takes care of freeing that item?
```

Change Summary:

rebase and remove some references we no longer needed to keep

Commits:

	Summary	ID
	Make the DisplayWindow use a GtkListView The traditional pattern of using a TreeView and Notebook/stack has been removed. This now use a ListView with a model that contains the child widgets, and an AdwBin where we swap the children in and out. I didn't implement everything, as now that this window is a bit more mixed content, things aren't as clear cut. I left some TODO's in the code describing these scenarios.	8a2284307f2bb770c8322b7f828ced5c2e352fc5
	Make the DisplayWindow use a GtkListView The traditional pattern of using a TreeView and Notebook/stack has been removed. This now use a ListView with a model that contains the child widgets, and an AdwBin where we swap the children in and out. I didn't implement everything, as now that this window is a bit more mixed content, things aren't as clear cut. I left some TODO's in the code describing these scenarios.	392840f0156459ea2af8418412fdb26b620a1214

Diff:

Revision 3 (+1912 -786)

Show changes

	pidgin/meson.build
	pidgin/pidgindisplayitem.h
	pidgin/pidgindisplayitem.c
	pidgin/pidgindisplaywindow.c
	pidgin/resources/Display/window.ui

Ship it!

```
Ship It!
```

Review Board 6.0.2

Make the DisplayWindow use a GtkListView

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)