Simplify the buffers by making everything work on a TalkatuBuffer

 






 

 


  Review Request #2224
  —
  Created Jan. 31, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  grim
 









 
 

  talkatu/talkatu
 









 
 

  default
 









 
 

  
 









 
 

  2213
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
The only things the content type specific buffers were doing now as defining
which formatting actions would be enabled. So we now created an flags and a
property on TalkatuActionGroup to fix that. By doing so, we are able to get
rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.

 








  


 
 

  
Ran the demo, tested all the buffers as well as the insert html and mark down actions.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3
4

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Simplify the buffers by making everything work on a TalkatuBuffer
     
The only things the content type specific buffers were doing now as defining
which formatting actions would be enabled. So we now created an flags and a
property on TalkatuActionGroup to fix that. By doing so, we are able to get
rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.

    

   
  		
  df5c478b12de9cd16a694ce5fda34dfe5ef39aab
  Gary Kramlich
 


 
  
 
 
  
   
    

     Simplify the buffers by making everything work on a TalkatuBuffer
     
The only things the content type specific buffers were doing now as defining
which formatting actions would be enabled. So we now created an flags and a
property on TalkatuActionGroup to fix that. By doing so, we are able to get
rid of TalkatuHTMLBuffer, TalkatuMarkdownBuffer, and TalkatuWholeBuffer.

    

   
  		
  346fe3a1470e162502b66758bd3e9d89ea9fed45
  Gary Kramlich
 




    


    
    

   

  

 









 

  

   
    

     
      
      talkatu/talkatuactiongroup.c
     
    

   
  

 



 

  

   
    

     
      
      talkatu/talkatubuffer.c
     
    

   
  

 



 

  

   
    

     
      
      talkatu/talkatumarkdown.c
     
    

   
  

 










     

    

   

  

  

   
   Loading...