IRCv3: Get SCRAM-SHA-256 working

Review Request #2223 — Created Jan. 28, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This took a bit of trouble shooting, but gsasl does all the work which is very
nice. I cleaned up some logic around the server_in buffer as well, and we may
need to lock down the logic a bit in purple_ircv3_sasl_authenticate a bit, but
everything seems fine for now.

Use the SASL mechanisms account option to force PLAIN and SCRAM-SHA-256 on my local ergo instance and verified via ngrep that only those mechs were used.

I also deleted the values from the SASL mechanisms account option and verified it fell back to PLAIN that the server advertises. ergo doesn't advertise SCRAM-SHA-256 for some reason, which is why this needed to depend on /r/2222.

Summary ID
Get SCRAM-SHA-256 working with IRCv3
This took a bit of trouble shooting, but gsasl does all the work which is very nice. I cleaned up some logic around the server_in buffer as well, and we may need to lock down the logic a bit in purple_ircv3_sasl_authenticate a bit, but everything seems fine for now.
e895ef47fdd52bca9dd53e47d90cfd4c01279fad
grim
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...