Summary

IRCv3: Add detail to the ack and nak signals for PurpleIRCv3Capabilities

Review Request #2221 — Created Jan. 28, 2023 and submitted Jan. 29, 2023, 6:07 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17743

Depends On

Reviewers

Groups

pidgin

People

Description

This allows you to tell g_signal_connect what capability you care about when
connecting to the signals. This avoids your signal callback being called
multiple times and having to do a string comparison to check if it's the
capability you care about.

Testing Done

Added a g_warning to purple_ircv3_sasl_ack_cb and verified it only got called for sasl and not cap-notify.

Commits

Summary	ID
Add detail to the ack and nak signals for PurpleIRCv3Capabilities This allows you to tell g_signal_connect what capability you care about when connecting to the signals. This avoids your signal callback being called multiple times and having to do a string comparison to check if it's the capability you care about.	e7e910a424d90d6c2e9e1785dae824d09398a7cf

Summary:

-	Add detail to the ack and nak signals for PurpleIRCv3Capabilities
+	IRCv3: Add detail to the ack and nak signals for PurpleIRCv3Capabilities

Ship it!

```
Ship It!
```

Review Board 6.0.2

IRCv3: Add detail to the ack and nak signals for PurpleIRCv3Capabilities

Information

Reviewers

Summary:

Status: Closed (submitted)