Summary

Don't unref the an object we don't own a reference to

Review Request #2175 — Created Jan. 5, 2023 and submitted Jan. 6, 2023, 3:13 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

purple_conversation_manager_find is transfer none, so we only want to unref when we create a new conversation as the manager will add its own reference.

Testing Done

Connected to libera with ircv3 and verified the crash was gone.

Commits

Summary	ID
Don't unref the an object we don't own a reference to	b73d73275e32cf3fe6560cae5689dae5806d5d1c

Issues

Description	From	Last Updated
its	QuLogic	Jan. 6, 2023, 12:02 a.m.

Change Summary:

Fix typo

Description:

~		`purple_conversation_manager_find` is transfer none, so we only want to unref when we create a new conversation as the manager will add it's own reference.
	~	`purple_conversation_manager_find` is transfer none, so we only want to unref when we create a new conversation as the manager will add its own reference.

libpurple/protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)
Show all issues
```
its
```

Change Summary:

fix typo

Commits:

	Summary	ID
	Don't unref the an object we don't own a reference to	e1e5112ab9977044a48198e93e8c6bb313bb54b1
	Don't unref the an object we don't own a reference to	b73d73275e32cf3fe6560cae5689dae5806d5d1c