-
-
-
pidgin/gtkblist.c (Diff revision 1) Unfortunately
G_SOURCE_REMOVEwasn't added until glib 2.32 and the Windows build only has 2.16. So this needs to be replaced withFALSE. -
pidgin/gtkblist.c (Diff revision 1) This would be a bit more readable if you create a variable for the function, something like
GtkTreeViewSearchPositionFunc func = user_data; ... func(tree_view, search_dialog, NULL);Also note that we should probably be passing
NULLas the user data, as even if the function was expecting user data, it probably isn't expecting a function pointer to itself.Also these lines need to be formatted to not wrap.
-
pidgin/gtkblist.c (Diff revision 1) Correct me if I'm wrong, but this appears to iterate the entire blist structure to collapse any nodes that were expanded for the search. Which is fine, but having it in a
GtkTreeViewSearchEqualFuncis a problem.This function get called for every row in the tree, which means we're iterating all of the groups in the tree every time a row is checked for equality. Which is going to take a very long time for large blists.
I think a better place to put this is in the wrapper function for the
GtkTreeViewSearchPositionFunc. But I realize that might not be enough as we don't know when the user has changed the search term, but presumably the timeout will take care of it? -
pidgin/gtkblist.c (Diff revision 1) This only iterates through chats and contacts and skips over buddies.
-
pidgin/gtkblist.c (Diff revision 1) This should at least have
NULL);on it's own line, but it might just be better to drop the existing function into a variable and use that instead.
Make collapsed groups searchable in the buddy list
Review Request #2167 — Created Jan. 3, 2023 and discarded
Searching collapsed groups works by expanding them as they are
traversed by the search function. To mitigate leaving behind
expanded groups that were previously collapsed by the user,
the groups that were expanded by the search are flagged as
such so that they can be collapsed back automatically.The search is started by typing while the Buddy List
window is active, or by pressing CTRL+F in the Buddy List.
Use the UP and DOWN arrow keys to move to the previous and
next matches.
Tested on Debian Sid and Cinnamon DE
| Summary | ID |
|---|---|
| fe3bf88f570dd8bcfcd38c51321284ede14e65a1 |
| Description | From | Last Updated |
|---|---|---|
|
Unfortunately G_SOURCE_REMOVE wasn't added until glib 2.32 and the Windows build only has 2.16. So this needs to be replaced … |
 grim
|
|
|
This would be a bit more readable if you create a variable for the function, something like GtkTreeViewSearchPositionFunc func = … |
grim
|
|
|
Correct me if I'm wrong, but this appears to iterate the entire blist structure to collapse any nodes that were … |
grim
|
|
|
This only iterates through chats and contacts and skips over buddies. |
grim
|
|
|
This should at least have NULL); on it's own line, but it might just be better to drop the existing … |
grim
|
