Replace all of the deprecated account api in Gadu Gadu

Review Request #2138 — Created Dec. 14, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

Replace all of the deprecated account api in Gadu Gadu

Touched all the files and compiled and verified there were not deprecation warnings.

Summary ID
Replace all of the deprecated account api in Gadu Gadu
123450f02249c5e76d73d847155554c3a43eec5e
Description From Last Updated

Did you really want the blank line between the two variables, and not the regular code?

QuLogicQuLogic

You already have an info variable above?

QuLogicQuLogic

Probably want to move username above as well.

QuLogicQuLogic

Looking through everything, it seems like they should have been calling this ggp_own_uin and then you wouldn't have to change …

QuLogicQuLogic

ggp_str_to_uin returns uin_t, not uint64_t.

QuLogicQuLogic

And this is a duplicate of ggp_own_uin?

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/protocols/gg/chat.c (Diff revision 1)
     
     
     
     

    Did you really want the blank line between the two variables, and not the regular code?

  3. libpurple/protocols/gg/chat.c (Diff revision 1)
     
     

    You already have an info variable above?

  4. libpurple/protocols/gg/chat.c (Diff revision 1)
     
     

    Probably want to move username above as well.

    1. The variable is named username, but it's calling name_for_display

  5. libpurple/protocols/gg/gg.c (Diff revision 1)
     
     

    Looking through everything, it seems like they should have been calling this ggp_own_uin and then you wouldn't have to change so many places so much.

    1. that was kind of my thoughts too, but i didn't want to get that deep into the prpl.

  6. libpurple/protocols/gg/image-prpl.c (Diff revision 1)
     
     

    ggp_str_to_uin returns uin_t, not uint64_t.

  7. libpurple/protocols/gg/utils.c (Diff revision 1)
     
     

    And this is a duplicate of ggp_own_uin?

    1. apparently, the code does seem a bit messy...

  8. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...