-
-
libpurple/protocols/gg/chat.c (Diff revision 1) Did you really want the blank line between the two variables, and not the regular code?
-
-
-
libpurple/protocols/gg/gg.c (Diff revision 1) Looking through everything, it seems like they should have been calling this
ggp_own_uinand then you wouldn't have to change so many places so much. -
-
Replace all of the deprecated account api in Gadu Gadu
Review Request #2138 — Created Dec. 13, 2022 and submitted
| Information | |
|---|---|
| grim | |
| pidgin/pidgin | |
| default | |
| Reviewers | |
| pidgin | |
Replace all of the deprecated account api in Gadu Gadu
Touched all the files and compiled and verified there were not deprecation warnings.
| Summary |
|---|
| Description | From | Last Updated |
|---|---|---|
|
Did you really want the blank line between the two variables, and not the regular code? |
 QuLogic
|
|
|
You already have an info variable above? |
QuLogic
|
|
|
Probably want to move username above as well. |
QuLogic
|
|
|
Looking through everything, it seems like they should have been calling this ggp_own_uin and then you wouldn't have to change … |
QuLogic
|
|
|
ggp_str_to_uin returns uin_t, not uint64_t. |
QuLogic
|
|
|
And this is a duplicate of ggp_own_uin? |
QuLogic
|
Change Summary:
Address the main issues
Commits: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+178 -90) |