Summary

Clean up PurpleWhiteboardManager

Review Request #2082 — Created Nov. 23, 2022 and submitted Nov. 24, 2022, 12:05 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Implement the GListModel interface backed by a GPtrArray.
Remove the for_each method as it's not used or necessary with a model.

Testing Done

Ran the unit tests and built the docs.

Commits

Summary	ID
Clean up PurpleWhiteboardManager Implement the GListModel interface backed by a GPtrArray. Remove the for_each method as it's not used or necessary with a model.	dcd4a64c0b2dfdc750bcfc2a07333ff3ab0665fe

Issues

Description	From	Last Updated
This function return is transfer full, but this call is not.	QuLogic	Nov. 24, 2022, 12:02 a.m.

libpurple/purplewhiteboardmanager.c (Diff revision 1)

Show all issues

This function return is transfer full, but this call is not.

Fix transfer annotation

	Summary	ID
	Clean up PurpleWhiteboardManager Implement the GListModel interface backed by a GPtrArray. Remove the for_each method as it's not used or necessary with a model.	8c282dd01776bfee437b9ad895c81208a1c1e3e0
	Clean up PurpleWhiteboardManager Implement the GListModel interface backed by a GPtrArray. Remove the for_each method as it's not used or necessary with a model.	dcd4a64c0b2dfdc750bcfc2a07333ff3ab0665fe

Revision 2 (+182 -186)

	libpurple/purplewhiteboardmanager.h
	libpurple/purplewhiteboardmanager.c

Ship it!

Review Board 6.0.2