Summary

Don't allow duplicate tags in PurpleTags

Review Request #2053 — Created Nov. 10, 2022 and submitted Nov. 10, 2022, 5:19 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Originally I was thinking it might be useful to store counter objects in the
tags, but that adds a bunch of complexity to the serialization layer and tag
users can just get the existing tag, and then increment the value themselves.

Testing Done

Ran the unit tests.

Commits

Summary	ID
Don't allow duplicate tags in PurpleTags Originally I was thinking it might be useful to store counter objects in the tags, but that adds a bunch of complexity to the serialization layer and tag users can just get the existing tag, and then increment the value themselves.	7bcaf96239ba68a6146aefd9d3dd479dcb8ac0b4

Issues

Description	From	Last Updated
will be replaced?	QuLogic	Nov. 10, 2022, 5:06 a.m.

libpurple/purpletags.h (Diff revision 1)
Show all issues
```
will be replaced?
```

Change Summary:

fix typo

Commits:

	Summary	ID
	Don't allow duplicate tags in PurpleTags Originally I was thinking it might be useful to store counter objects in the tags, but that adds a bunch of complexity to the serialization layer and tag users can just get the existing tag, and then increment the value themselves.	0254d811520a9339ebb3c288cf3311f5cab4881b
	Don't allow duplicate tags in PurpleTags Originally I was thinking it might be useful to store counter objects in the tags, but that adds a bunch of complexity to the serialization layer and tag users can just get the existing tag, and then increment the value themselves.	7bcaf96239ba68a6146aefd9d3dd479dcb8ac0b4

Diff:

Revision 2 (+16 -6)

Show changes

	libpurple/purpletags.h
	libpurple/purpletags.c
	libpurple/tests/test_tags.c

Ship it!

```
Ship It!
```

Review Board 6.0.2