Summary

De-privatize more Facebook internals

Review Request #2016 — Created Nov. 4, 2022 and submitted Nov. 4, 2022, 3:53 a.m.

Owner

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

I have no idea why I didn't do these in /r/1822.

Testing Done

Compile only.

Commits

Summary	ID
De-privatize more Facebook internals	f73f0357044fdf33d42ee29cb52fc3ad3eb0e867

Ship it!

Fix an off-by-one.
The previous (*(byte++) & 128) != 0 would increment byte on the final comparison, so we need to as well in the while loop version.

	Summary	ID
	De-privatize more Facebook internals	26b5ad3db41b3bff08497034b92554f0c59a06cf
	De-privatize more Facebook internals	f73f0357044fdf33d42ee29cb52fc3ad3eb0e867

Revision 2 (+354 -534)

	libpurple/protocols/facebook/data.c
	libpurple/protocols/facebook/json.c
	libpurple/protocols/facebook/mqtt.c

Ship it!

Review Board 6.0.2