Summary

Display a dialog in Pidgin if purple_core_init returned FALSE

Review Request #2007 — Created Nov. 1, 2022 and submitted Nov. 1, 2022, 5:06 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17698

Depends On

Reviewers

Groups

pidgin

People

Description

This also adds an environment variable so developers (or users for some reason)
can set a custom error message for purple_core_init to return. The intent is to
allow UI developers to control the message and make sure things display as they
expect them to.

Testing Done

used the PURPLE3_CORE_ERROR_MESSAGE environment variable to test the dialog including one with multiple lines of a's with no breaks and everything displayed fine.

Commits

Summary	ID
Display a dialog in Pidgin if purple_core_init returned FALSE This also adds an environment variable so developers (or users for some reason) can set a custom error message for purple_core_init to return. The intent is to allow UI developers to control the message and make sure things display as they expect them to.	57722793955cd7f33da5ba025ee52ef5e0b6fbc4

Issues

Description	From	Last Updated
s/this to/this/	QuLogic	Nov. 1, 2022, 5:03 a.m.
Can drop the with.	QuLogic	Nov. 1, 2022, 5:03 a.m.

Ship it!

```
Ship It!
```
libpurple/core.c (Diff revision 1)
Show all issues
```
s/this to/this/
```
libpurple/core.c (Diff revision 1)
Show all issues
```
Can drop the with.
```

Change Summary:

address issues

Commits:

	Summary	ID
	Display a dialog in Pidgin if purple_core_init returned FALSE This also adds an environment variable so developers (or users for some reason) can set a custom error message for purple_core_init to return. The intent is to allow UI developers to control the message and make sure things display as they expect them to.	8a635556ca41e98d681c16d319f1edac4c372d7a
	Display a dialog in Pidgin if purple_core_init returned FALSE This also adds an environment variable so developers (or users for some reason) can set a custom error message for purple_core_init to return. The intent is to allow UI developers to control the message and make sure things display as they expect them to.	57722793955cd7f33da5ba025ee52ef5e0b6fbc4

Diff:

Revision 2 (+96 -10)

Show changes

	libpurple/core.c
	pidgin/pidginapplication.c

Bugs:

+	PIDGIN-17698

Review Board 6.0.2