Summary

Port gnttinyurl plugin to libsoup3

Review Request #1961 — Created Oct. 25, 2022 and submitted Oct. 26, 2022, 7:06 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~1960~~

Reviewers

Groups

pidgin

People

Description

This covers both adding the SoupMessage to an existing callback data structure, and using SoupMessage as the callback data with "real" callback data attached to it.

Testing Done

Compiled against libsoup2 and libsoup3.

Commits

Summary	ID
Port gnttinyurl plugin to libsoup3	6707bf9fe6cb0c476533e52a3a9b2910917fbed8

Issues

Description	From	Last Updated
If we don't finish, the result just sits in limbo no?	grim	Oct. 25, 2022, 6:52 a.m.
"cancel it" perhaps?	grim	Oct. 26, 2022, 7:05 a.m.
where does g_cancellable_cancel come from?	grim	Oct. 25, 2022, 6:04 a.m.

finch/plugins/gnttinyurl/gnttinyurl.c (Diff revision 1)

Show all issues

If we don't finish, the result just sits in limbo no?

QuLogic Oct. 25, 2022, 6:29 a.m.

libsoup uses GTask for async results, and g_task_propagate_pointer "steals" the result from the task. That means if you don't call finish, the task still owns it and will free the result with the GDestroyNotify that was given to g_task_return_pointer. So I don't think we need to call finish always.

grim Oct. 25, 2022, 6:52 a.m.

Right right, this coming back to me now. The issue I was remembering was when we were trying to early fail in the _async method.

finch/plugins/gnttinyurl/gnttinyurl.c (Diff revision 1)
Show all issues
```
"cancel it" perhaps?
```
finch/plugins/gnttinyurl/gnttinyurl.c (Diff revision 1)
Show all issues
```
where does g_cancellable_cancel come from?
```
1. grim Oct. 25, 2022, 6:04 a.m.
  glib... 🤦

Change Summary:

Clarify comment and fix some whitespace.

Commits:

	Summary	ID
	Port gnttinyurl plugin to libsoup3	60cec6b4d26b5acf7664cec70e08354111d1471d
	Port gnttinyurl plugin to libsoup3	6707bf9fe6cb0c476533e52a3a9b2910917fbed8

Diff:

Revision 2 (+110 -72)

Show changes

finch/plugins/gnttinyurl/gnttinyurl.c

Ship it!

```
Ship It!
```
```
Great work, thanks!!
```

Review Board 6.0.2