Summary

Fix connection errors getting deleted when an account is disconnected

Review Request #1944 — Created Oct. 23, 2022 and submitted Oct. 23, 2022, 7:19 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

1947, 1945

Reviewers

Groups

pidgin

People

Description

Fix connection errors getting deleted when an account is disconnected

Testing Done


Ran the unit tests with the new test
Caused a resource conflict on XMPP to verify that notification was displayed
Attempted to connect an IRC account that had a bad hostname and verified that notification was displayed.
Not integration testing was done for Finch.

Commits

Summary	ID
Fix connection errors getting deleted when an account is disconnected	cd2f5442b93e82c1ddf1bb59127b46b7f5cd6cfb

Issues

Description	From	Last Updated
notifications	QuLogic	Oct. 23, 2022, 7:08 a.m.
These are treated differently from the other notifications tied to accounts, as those are transient and ...	QuLogic	Oct. 23, 2022, 7:08 a.m.
I think you can't just continue, as if you have something like: notification 1 (account1, not connection error) notification 2 …	QuLogic	Oct. 23, 2022, 7:08 a.m.
notifications	QuLogic	Oct. 23, 2022, 7:08 a.m.
fourth	QuLogic	Oct. 23, 2022, 7:16 a.m.
position zero.	QuLogic	Oct. 23, 2022, 7:16 a.m.
s/call empty/empty/ s/it's/its/	QuLogic	Oct. 23, 2022, 7:16 a.m.
4, or maybe leave out the number.	QuLogic	Oct. 23, 2022, 7:16 a.m.

libpurple/purplenotificationmanager.h (Diff revision 1)
Show all issues
```
notifications
```

libpurple/purplenotificationmanager.h (Diff revision 1)

Show all issues

These are treated differently from the other notifications tied to accounts, as those are transient and ...

libpurple/purplenotificationmanager.c (Diff revision 1)

Show all issues

I think you can't just continue, as if you have something like:

notification 1 (account1, not connection error)
notification 2 (account2, connection error)
notification 3 (account1, not connection error)

and you are deleting account1, then the continue will not trigger a have_same change for notification 2, and it will believe it should remove all notifications.

libpurple/tests/test_notification_manager.c (Diff revision 1)
Show all issues
```
notifications
```

Change Summary:

Address issues, fix the handling of connection errors, and remove the attempts to linking to an enum member as that is not supported by gi-docgen.

Commits:

	Summary	ID
	Fix connection errors getting deleted when an account is disconnected	6eec14d6c45cb9251ffaa79899b27edd04be3677
	Fix connection errors getting deleted when an account is disconnected	d2675700b6c6f914f13c19a8b86aa5ead7fb9001

Diff:

Revision 2 (+254 -20)

Show changes

	finch/gntaccount.c
	libpurple/account.c
	libpurple/purplenotificationmanager.h
	libpurple/purplenotificationmanager.c
	libpurple/tests/test_notification_manager.c
	pidgin/pidginaccountmanager.c

libpurple/tests/test_notification_manager.c (Diff revision 2)
Show all issues
```
fourth
```
libpurple/tests/test_notification_manager.c (Diff revision 2)
Show all issues
```
position zero.
```
libpurple/tests/test_notification_manager.c (Diff revision 2)
Show all issues
```
s/call empty/empty/

s/it's/its/
```
libpurple/tests/test_notification_manager.c (Diff revision 2)
Show all issues
```
4, or maybe leave out the number.
```

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Fix connection errors getting deleted when an account is disconnected	d2675700b6c6f914f13c19a8b86aa5ead7fb9001
	Fix connection errors getting deleted when an account is disconnected	cd2f5442b93e82c1ddf1bb59127b46b7f5cd6cfb

Diff:

Revision 3 (+254 -20)

Show changes

	finch/gntaccount.c
	libpurple/account.c
	libpurple/purplenotificationmanager.h
	libpurple/purplenotificationmanager.c
	libpurple/tests/test_notification_manager.c
	pidgin/pidginaccountmanager.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Fix connection errors getting deleted when an account is disconnected

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)