Summary

Back out the PurpleProtocol->login change that returned a PurpleConnection

Review Request #1937 — Created Oct. 18, 2022 and submitted Oct. 19, 2022, 11:27 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This remains to be a good idea, but this implementation caused more issues than
it solved. I'm working on that better implementation, but we need to revert all
of this first, otherwise the new review request is going to be massive.

This reverts commits 3f96e2b2b03d, d567f89d6a9b, and 6ef5bb284651. These were
backed out manually due to some other commits that made automative backouts
difficult.

Testing Done

Connected a demo, ircv3, and xmpp accounts without issue.

Commits

Summary	ID
Back out the PurpleProtocol->login change that returned a PurpleConnection This remains to be a good idea, but this implementation caused more issues than it solved. I'm working on that better implementation, but we need to revert all of this first, otherwise the new review request is going to be massive. This reverts commits 3f96e2b2b03d, d567f89d6a9b, and 6ef5bb284651. These were backed out manually due to some other commits that made automative backouts difficult.	00d3bffbecfbf2fc72cbab4ca6a2ec26db5cedf2

Summary

Back out the PurpleProtocol->login change that returned a PurpleConnection

This remains to be a good idea, but this implementation caused more issues than it solved. I'm working on that better implementation, but we need to revert all of this first, otherwise the new review request is going to be massive. This reverts commits 3f96e2b2b03d, d567f89d6a9b, and 6ef5bb284651. These were backed out manually due to some other commits that made automative backouts difficult.

00d3bffbecfbf2fc72cbab4ca6a2ec26db5cedf2

Issues

Description	From	Last Updated
protocol is unused now.	QuLogic	Oct. 19, 2022, 7:08 a.m.
Extraneous return.	QuLogic	Oct. 19, 2022, 7:08 a.m.
protocol is unused now.	QuLogic	Oct. 19, 2022, 7:08 a.m.
protocol is unused now.	QuLogic	Oct. 19, 2022, 7:08 a.m.
protocol is unused now.	QuLogic	Oct. 19, 2022, 7:08 a.m.
This cast is invalid now.	QuLogic	Oct. 19, 2022, 7:09 a.m.
Should use purple_connection.	QuLogic	Oct. 19, 2022, 7:09 a.m.
protocol is unused now.	QuLogic	Oct. 19, 2022, 7:09 a.m.
protocol is unused now.	QuLogic	Oct. 19, 2022, 7:09 a.m.
Extra return.	QuLogic	Oct. 18, 2022, 5:40 a.m.

Change Summary:

fix a warning i missed somehow

Commits:

	Summary	ID
	Back out the PurpleProtocol->login change that returned a PurpleConnection This remains to be a good idea, but this implementation caused more issues than it solved. I'm working on that better implementation, but we need to revert all of this first, otherwise the new review request is going to be massive. This reverts commits 3f96e2b2b03d, d567f89d6a9b, and 6ef5bb284651. These were backed out manually due to some other commits that made automative backouts difficult.	c5bfe1a73a07a6ace93957d422c210253da2a115
	Back out the PurpleProtocol->login change that returned a PurpleConnection This remains to be a good idea, but this implementation caused more issues than it solved. I'm working on that better implementation, but we need to revert all of this first, otherwise the new review request is going to be massive. This reverts commits 3f96e2b2b03d, d567f89d6a9b, and 6ef5bb284651. These were backed out manually due to some other commits that made automative backouts difficult.	7b194129c5bbbb09890392a6e408acb00c2fa173

Diff:

Revision 2 (+442 -390)

Show changes

	libpurple/connection.h
	libpurple/connection.c
	libpurple/purpleprotocol.h
	libpurple/purpleprotocol.c
	libpurple/protocols/bonjour/bonjour.c
	libpurple/protocols/demo/purpledemoprotocol.c
	libpurple/protocols/facebook/facebook.c
	libpurple/protocols/gg/gg.c
	10 more

libpurple/protocols/bonjour/bonjour.c (Diff revision 1)
Show all issues
```
protocol is unused now.
```
libpurple/protocols/bonjour/bonjour.c (Diff revision 1)
Show all issues
```
Extraneous return.
```
libpurple/protocols/demo/purpledemoprotocol.c (Diff revision 1)
Show all issues
```
protocol is unused now.
```
libpurple/protocols/gg/gg.c (Diff revision 1)
Show all issues
```
protocol is unused now.
```
libpurple/protocols/irc/irc.c (Diff revision 1)
Show all issues
```
protocol is unused now.
```
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
Show all issues
```
This cast is invalid now.
```
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
Show all issues
```
Should use purple_connection.
```
libpurple/protocols/ircv3/purpleircv3protocol.c (Diff revision 1)
Show all issues
```
protocol is unused now.
```
libpurple/protocols/novell/novell.c (Diff revision 1)
Show all issues
```
protocol is unused now.
```
libpurple/purpleprotocol.c (Diff revision 1)
Show all issues
```
Extra return.
```

Change Summary:

address issues

Commits:

	Summary	ID
	Back out the PurpleProtocol->login change that returned a PurpleConnection This remains to be a good idea, but this implementation caused more issues than it solved. I'm working on that better implementation, but we need to revert all of this first, otherwise the new review request is going to be massive. This reverts commits 3f96e2b2b03d, d567f89d6a9b, and 6ef5bb284651. These were backed out manually due to some other commits that made automative backouts difficult.	7b194129c5bbbb09890392a6e408acb00c2fa173
	Back out the PurpleProtocol->login change that returned a PurpleConnection This remains to be a good idea, but this implementation caused more issues than it solved. I'm working on that better implementation, but we need to revert all of this first, otherwise the new review request is going to be massive. This reverts commits 3f96e2b2b03d, d567f89d6a9b, and 6ef5bb284651. These were backed out manually due to some other commits that made automative backouts difficult.	00d3bffbecfbf2fc72cbab4ca6a2ec26db5cedf2

Diff:

Revision 3 (+454 -392)

Show changes

	libpurple/connection.h
	libpurple/connection.c
	libpurple/purpleprotocol.h
	libpurple/purpleprotocol.c
	libpurple/protocols/bonjour/bonjour.c
	libpurple/protocols/demo/purpledemoprotocol.c
	libpurple/protocols/facebook/facebook.c
	libpurple/protocols/gg/gg.c
	10 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

Back out the PurpleProtocol->login change that returned a PurpleConnection

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)

libpurple/protocols/gg/gg.c (Diff revision 1)

libpurple/purpleprotocol.c (Diff revision 1)