Summary

Update PurpleProtocolClass->login to return a PurpleConnection

Review Request #1912 — Created Oct. 9, 2022 and submitted Oct. 9, 2022, 4:48 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Update PurpleProtocolClass->login to return a PurpleConnection

Testing Done

Connected a demo, ircv3, and xmpp account.

Commits

Summary	ID
Update PurpleProtocolClass->login to return a PurpleConnection	2f5e5c9bfd50bbe0cfa80f9eab44ac632b8ef7bb

Issues

Description	From	Last Updated
Brace on new line.	QuLogic	Oct. 9, 2022, 2:50 a.m.
Based on all the implementations, I wonder if that should be return PurpleConnection, or return NULL and fill a GError. …	QuLogic	Oct. 9, 2022, 2:50 a.m.

libpurple/protocols/jabber/jabber.c (Diff revision 1)
Show all issues
```
Brace on new line.
```

libpurple/purpleprotocol.h (Diff revision 1)

Show all issues

Based on all the implementations, I wonder if that should be return PurpleConnection, or return NULL and fill a GError.
But I'm not sure where that GError would go to, so maybe nothing to change right now.

grim Oct. 9, 2022, 2:38 a.m.

I think NULL and return a GError is a great place to go, but we need to wind a few more things before we can do that I think.

grim Oct. 9, 2022, 2:39 a.m.
```
*unwind
```

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Update PurpleProtocolClass->login to return a PurpleConnection	0253f17092d61a578a60dbc8a5ebd7bc2e1c1377
	Update PurpleProtocolClass->login to return a PurpleConnection	2f5e5c9bfd50bbe0cfa80f9eab44ac632b8ef7bb

Diff:

Revision 2 (+308 -210)

Show changes

	libpurple/connection.h
	libpurple/connection.c
	libpurple/purpleprotocol.h
	libpurple/purpleprotocol.c
	libpurple/protocols/bonjour/bonjour.c
	libpurple/protocols/demo/purpledemoprotocol.c
	libpurple/protocols/facebook/facebook.c
	libpurple/protocols/gg/gg.c
	7 more

Ship it!

```
Ship It!
```

Review Board 6.0.2