Summary

Fix the docs and do some minor clean up for PurpleQueuedOutputStream

Review Request #1908 — Created Oct. 8, 2022 and submitted Oct. 8, 2022, 9:55 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Fix the docs and do some minor clean up for PurpleQueuedOutputStream

Testing Done

Built the docs and verified all of symbols were now documented.

Commits

Summary	ID
Fix the docs and do some minor clean up for PurpleQueuedOutputStream	df2626e11b5779a2ad980c605d5325312759b75f

Issues

Description	From	Last Updated
Argument name doesn't match.	QuLogic	Oct. 8, 2022, 9:36 a.m.
The other error doesn't have (optional); should be consistent.	QuLogic	Oct. 8, 2022, 9:31 a.m.
Space before =.	QuLogic	Oct. 8, 2022, 9:32 a.m.
This doesn't match the argument name. You should have got a warning about that.	QuLogic	Oct. 8, 2022, 9:50 a.m.

libpurple/queuedoutputstream.h (Diff revision 1)
Show all issues
```
Argument name doesn't match.
```

libpurple/queuedoutputstream.h (Diff revision 1)

Show all issues

The other error doesn't have (optional); should be consistent.

grim Oct. 8, 2022, 8:58 a.m.
```
uh which other error?
```

QuLogic Oct. 8, 2022, 9:31 a.m.

Ah, I'm not sure, I think I confused it with the cancellable.

libpurple/queuedoutputstream.c (Diff revision 1)
Show all issues
```
Space before =.
```

Change Summary:

address some of the issues.

Commits:

	Summary	ID
	Fix the docs and do some minor clean up for PurpleQueuedOutputStream	188307ddae0ca86ba1ea085a7c90de8469b728c6
	Fix the docs and do some minor clean up for PurpleQueuedOutputStream	3d02ee4bccae9d1c4b104c1df1c1bd7a225cc79f

Diff:

Revision 2 (+184 -210)

Show changes

	libpurple/queuedoutputstream.h
	libpurple/queuedoutputstream.c

libpurple/queuedoutputstream.h (Diff revision 2)

Show all issues

This doesn't match the argument name. You should have got a warning about that.

Change Summary:

fix parameter names

Commits:

	Summary	ID
	Fix the docs and do some minor clean up for PurpleQueuedOutputStream	3d02ee4bccae9d1c4b104c1df1c1bd7a225cc79f
	Fix the docs and do some minor clean up for PurpleQueuedOutputStream	df2626e11b5779a2ad980c605d5325312759b75f

Diff:

Revision 3 (+184 -210)

Show changes

	libpurple/queuedoutputstream.h
	libpurple/queuedoutputstream.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Fix the docs and do some minor clean up for PurpleQueuedOutputStream

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)