Summary

Make PurpleConnection derivable, which also means adding a private structure.

Review Request #1894 — Created Oct. 5, 2022 and submitted Oct. 7, 2022, 12:45 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

I also, probably stupidly renamed all the gc variables to connection.

Testing Done

Connected and disconnected a demo account, an irc account, and an xmpp account and verified no issues and nothing in the console.

Commits

Summary	ID
Make PurpleConnection derivable, which also means adding a private structure. I also, probably stupidly renamed all the gc variables to connection.	162794833a318fa80cea0da90ac6ce6c29de873e

Issues

Description	From	Last Updated
Can remove this newline.	QuLogic	Oct. 7, 2022, 10:01 a.m.
Can remove this newline.	QuLogic	Oct. 7, 2022, 10:01 a.m.
Looks like tabs?	QuLogic	Oct. 7, 2022, 10:01 a.m.

libpurple/connection.c (Diff revision 1)

Is the is_finalizing guard not necessary anymore? Same question for old line 223.

grim Oct. 6, 2022, 4:03 a.m.

These were added in https://keep.imfreedom.org/pidgin/pidgin/rev/2033f0755d68 which mentions "There may be a better fix possible, though" and that better fix is to just not notify from your destroy or finalize methods. We typically avoid this by not calling the setters from the aforementioned functions.

However, I'm getting all sorts of fun crashes on connection errors now. So I'm going to revert this particular change and we can try to fix it seprately at a later time.

grim Oct. 6, 2022, 4:11 a.m.

Upon further debugging, the crash is not related to this pull request in particular. I'll update more when I know more.

grim Oct. 6, 2022, 5:03 a.m.

I rebased on top of /r/1896 and saw no gobject warnings during shutdown. I did hit a invalid free in upnp_init but that's called LONG after connections are shutdown.

libpurple/connection.c (Diff revision 1)
Show all issues
```
Can remove this newline.
```
libpurple/connection.c (Diff revision 1)
Show all issues
```
Can remove this newline.
```
libpurple/connection.c (Diff revision 1)
Show all issues
```
Looks like tabs?
```

Change Summary:

address issues

Commits:

	Summary	ID
	Make PurpleConnection derivable, which also means adding a private structure. I also, probably stupidly renamed all the gc variables to connection.	1293624b50b653e9a5278111afac6c17a54ba409
	Make PurpleConnection derivable, which also means adding a private structure. I also, probably stupidly renamed all the gc variables to connection.	162794833a318fa80cea0da90ac6ce6c29de873e

Diff:

Revision 2 (+662 -398)

Show changes

	libpurple/connection.h
	libpurple/connection.c

Ship it!

```
Ship It!
```

Review Board 6.0.2