Remove extra focus targets from Account Editor

Review Request #1889 — Created Oct. 4, 2022 and submitted

QuLogic
pidgin/pidgin
default
pidgin

We only want the row's activatable widgets to get focus, not the rows themselves.

Opened new Account, selected XMPP with the keyboard, and focus went directly to the Username entry, instead of the row around it. Similarly, switching proxy on focused the Hostname entry directly instead of the row it's in.

Tabbing from the Username then continued down the entries only, the "Require password" switch, the "Use custom avatar" switch (and the image/remove buttons if I toggled that on), the activatable widgets in the Advanced Options (if enabled), and similar for the Proxy fields.

Summary
Remove extra focus targets from Account Editor
grim
  1. Ship It!
  2. Awesome, thanks for getting this done. I kept hitting it and then forgetting to fix it :-D

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...