Review Request #1682 — Created Aug. 30, 2022 and submitted
| Information | |
|---|---|
| QuLogic | |
| pidgin/pidgin | |
| default | |
| Reviewers | |
| pidgin | |
Also switched from
GtkProgressBartoGtkLevelBar, which seemed more appropriate. The number of levels was copied from the GNOME audio settings page.Also switched from
GtkAspectFrametoGtkPicture, as it is likely that GStreamer will use aGdkPaintableor some such in the future, based on the blog post we've found.More work for the devices can be done later, but needs some internal rework for list models first.
Changed some options, tried the
Test Audiobutton, which seemed to work. Also triedTest Videooption, but it fails as expected due to using GTK3 GStreamer widgets.
| Summary |
|---|
Semi-fix the styling of the level bar. Strangely, though the low level is set by the silence threshold, and the full/high are both at 19, I never see a low style when input is below the threshold. Instead the style seems to go from high to full at the low level. But so long as there's some change between the threshold, this is good enough.
Commits: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+350 -410) |
