Summary

Move VV preferences to Adwaita preference widgets

Review Request #1682 — Created Aug. 30, 2022 and submitted Aug. 30, 2022, 3:17 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Also switched from GtkProgressBar to GtkLevelBar, which seemed more appropriate. The number of levels was copied from the GNOME audio settings page.

Also switched from GtkAspectFrame to GtkPicture, as it is likely that GStreamer will use a GdkPaintable or some such in the future, based on the blog post we've found.

More work for the devices can be done later, but needs some internal rework for list models first.

Testing Done

Changed some options, tried the Test Audio button, which seemed to work. Also tried Test Video option, but it fails as expected due to using GTK3 GStreamer widgets.

Commits

Summary	ID
Move VV preferences to Adwaita preference widgets	ac0547b56c2c5e57f8a66f9b1df01e2438bd65ac

Files

Change Summary:

Semi-fix the styling of the level bar. Strangely, though the low level is set by the silence threshold, and the full/high are both at 19, I never see a low style when input is below the threshold. Instead the style seems to go from high to full at the low level. But so long as there's some change between the threshold, this is good enough.

Commits:

	Summary	ID
	Move VV preferences to Adwaita preference widgets	76a28b9ac614c0882542388c07cc6367eda69daf
	Move VV preferences to Adwaita preference widgets	ac0547b56c2c5e57f8a66f9b1df01e2438bd65ac

Diff:

Revision 2 (+350 -410)

Show changes

	pidgin/prefs/pidginvvprefs.c
	pidgin/resources/Prefs/vv.ui

Ship it!

```
Ship It!
```
```
Great work, thanks!!
```

Review Board 6.0.2