Summary

Move network preferences to Adwaita preference widgets

Review Request #1680 — Created Aug. 30, 2022 and submitted Aug. 30, 2022, 3:07 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~1677~~

Reviewers

Groups

pidgin

People

Description

This does make the TURN server settings longer vertically, but that seems more consistent with everything.

Also fix the leave event on the TURN server setting.

Testing Done

Toggled all the options and checked that stuff happened in the Debug Window.
Also, I'm not sure why the GtkSpinButton and GtkEntry expand to different sizes; they both have hexpand=1, and the spin button is next to text that's shorter than the entry, but somehow ends up farther right. Seems like a bug in GTK.
PS, be careful of this page; it tries to get your public IP address and displays it when it succeeds.

Commits

Summary	ID
Move network preferences to Adwaita preference widgets	13c4dfb6a5c884eaa92104af3e7231eef030524b

Files

Change Summary:

Add additional testing note

Testing Done:

		Toggled all the options and checked that stuff happened in the Debug Window.

	+	Also, I'm not sure why the `GtkSpinButton` and `GtkEntry` expand to different sizes; they both have `hexpand=1`, and the spin button is next to text that's shorter than the entry, but somehow ends up farther right. Seems like a bug in GTK.
	+
		PS, be careful of this page; it tries to get your public IP address and displays it when it succeeds.

Ship it!

```
Ship It!
```
```
Looks great!! Thanks!
```

Review Board 6.0.2

Move network preferences to Adwaita preference widgets

Information

Reviewers

Change Summary:

Testing Done:

Status: Closed (submitted)