Remove redundant gtk_widget_show

Review Request #1668 — Created Aug. 28, 2022 and submitted

Information

pidgin/pidgin
gtk4

Reviewers

These widgets were just created, or never hidden. I did leave the show on the video widgets, as I don't know where they eventually originate.

Compiled only.

Summary ID
Remove redundant gtk_widget_show
These widgets were just created, or never hidden.
9fff043835ee39ab704405b1acc7ab38dc86fa8d
grim
  1. 
      
  2. The video widgets don't/won't matter. gstreamer doesn't build the gtk4 widgets by default because it queries everything up front which pulls in the libraries so they can't really provide gtk3 and gtk4 sinks at the same time and right now they've opted to continue support with the gtk3 widgets.

    I tried finding the blog post about just rendering a widget right from the pipeline but couldn't find it. Either way, that's a problem for another day.

  3. 
      
grim
  1. Ship It!
  2. Great work, thanks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...