Port about dialog to GTK4

Review Request #1649 — Created Aug. 26, 2022 and submitted

Information

pidgin/pidgin
gtk4

Reviewers

Port about dialog to GTK4

Opened the dialog, clicked the various options.

There is currently a warning about markdown_link_target, but that seems to be a bug in Talkatu (and the links all mush together, which I think is the same problem.) Also, strangely, the dialog sometimes opens exactly as wide as the bottom button box, but sometimes it opens a little bit wider (not sure if it's also Talkatu wrapping causing minor size request changes, or something else).

Summary ID
Port about dialog to GTK4
c65671920abe4e922d5b502ee7b11330978bd554
Description From Last Updated

Note, we cannot switch to <child type="action"> because that raises a warning that the GtkStackSwitcher is not actionable (though it …

QuLogicQuLogic

valign fill

grimgrim

valign

grimgrim
QuLogic
  1. 
      
  2. pidgin/pidginabout.c (Diff revision 1)
     
     

    This makes the first column really wide. The runtime directories are already in the second column, so moving them there is a bit better consistency, even if the first column is empty here.

  3. pidgin/resources/About/about.ui (Diff revision 1)
     
     

    Note, we cannot switch to <child type="action"> because that raises a warning that the GtkStackSwitcher is not actionable (though it does appear to work in the end.)

    1. Oops, wasn't supposed to be an issue.

  4. 
      
QuLogic
grim
  1. 
      
  2. pidgin/resources/About/about.ui (Diff revision 2)
     
     

    valign fill

  3. pidgin/resources/About/about.ui (Diff revision 2)
     
     
  4. 
      
QuLogic
grim
  1. Ship It!
  2. Great work, thank you!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...