Add user-joined and user-left gobject signals to PurpleChatConversation

Review Request #1606 — Created Aug. 19, 2022 and submitted

grim
pidgin/pidgin
default
pidgin
Add user-joined and user-left gobject signals to PurpleChatConversation

Joined a chat and verified everything worked as expected with no new warnings.

Summary
Add user-joined and user-left gobject signals to PurpleChatConversation
Description From Last Updated

I think you need chat (the signal object source) to be documented as well?

QuLogicQuLogic

I think you need chat (the signal object source) to be documented as well?

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/purplechatconversation.c (Diff revision 1)
     
     
     
     
     

    I think you need chat (the signal object source) to be documented as well?

    1. I forgot to test the docs, but I was looking at PurpleAccountManager::Added and noticed that the instance was not in the parameter list which is why I skipped it.

      https://docs.imfreedom.org/purple3/signal.AccountManager.added.html

    2. After testing, yes that is necessary.

  3. libpurple/purplechatconversation.c (Diff revision 1)
     
     
     
     

    I think you need chat (the signal object source) to be documented as well?

  4. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...