Summary

Add user-joined and user-left gobject signals to PurpleChatConversation

Review Request #1606 — Created Aug. 19, 2022 and submitted Aug. 19, 2022, 4:02 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Add user-joined and user-left gobject signals to PurpleChatConversation

Testing Done

Joined a chat and verified everything worked as expected with no new warnings.

Commits

Summary	ID
Add user-joined and user-left gobject signals to PurpleChatConversation	fc5df99a29439031b588f053cec2d4bb996879e0

Issues

Description	From	Last Updated
I think you need chat (the signal object source) to be documented as well?	QuLogic	Aug. 19, 2022, 3:57 a.m.
I think you need chat (the signal object source) to be documented as well?	QuLogic	Aug. 19, 2022, 3:58 a.m.

libpurple/purplechatconversation.c (Diff revision 1)

Show all issues

I think you need chat (the signal object source) to be documented as well?

grim Aug. 19, 2022, 3:44 a.m.

I forgot to test the docs, but I was looking at PurpleAccountManager::Added and noticed that the instance was not in the parameter list which is why I skipped it.

https://docs.imfreedom.org/purple3/signal.AccountManager.added.html

grim Aug. 19, 2022, 3:54 a.m.
```
After testing, yes that is necessary.
```

libpurple/purplechatconversation.c (Diff revision 1)

Show all issues

I think you need chat (the signal object source) to be documented as well?

Change Summary:

Add the instance to the doc comment so that all of the parameters will be documented as they're ignore if the instance isn't found.

Commits:

	Summary	ID
	Add user-joined and user-left gobject signals to PurpleChatConversation	8069af3664a9e69f36a49abe48deae3b8c81d036
	Add user-joined and user-left gobject signals to PurpleChatConversation	fc5df99a29439031b588f053cec2d4bb996879e0

Diff:

Revision 2 (+124 -2)

Show changes

libpurple/purplechatconversation.c

Ship it!

```
Ship It!
```

Review Board 6.0.2