Summary

When creating notifications for account errors, set the title so the UI's don't have to figure it out.

Review Request #1597 — Created Aug. 16, 2022 and submitted Aug. 16, 2022, 3:55 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

When creating notifications for account errors, set the title so the UI's don't have to figure it out.

Testing Done

Caused two connection errors and verified their titles were correct.

Commits

Summary	ID
When creating notifications for account errors, set the title so the UI's don't have to figure it out.	a3c279a7d11e5bc27300a4a4c49af58b874b7ff2

Issues

Description	From	Last Updated
How could title be NULL?	QuLogic	Aug. 16, 2022, 3:53 a.m.

~		Caused two connection errors and verified their title's were correct.
	~	Caused two connection errors and verified their titles were correct.

libpurple/account.c (Diff revision 1)

Show all issues

How could title be NULL?

It can't, I was being pedantic, but I'll remove it.

remove null check on title which can't be null

	Summary	ID
	When creating notifications for account errors, set the title so the UI's don't have to figure it out.	1c09402e50fddb19520ce2ed04c228c81073a725
	When creating notifications for account errors, set the title so the UI's don't have to figure it out.	a3c279a7d11e5bc27300a4a4c49af58b874b7ff2

	libpurple/account.c
	pidgin/pidginnotificationconnectionerror.c

Ship it!

Review Board 6.0.2