Description: |
|
---|
Modernize XMPP discovery plugin
Review Request #1596 — Created Aug. 16, 2022 and submitted
By porting common triggers to actions, dialog buttons to action widgets,
GtkMenu
toGtkPopoverMenu
, using theg_rc_box
API, and add braces everywhere. These will mostly make porting to GTK4 easier.Also, added a default Service name of the JID. Otherwise, looking at
xmpp.org
, you previously got a big list of empty-looking rows (which also warn when the tooltip is shown).
Opened plugin window, Browsed to
xmpp.org
andpidgin.im
, checked that the Add button opened the Add-to-chat dialog, checked that double-click did the same, checked that the menu item did the same. I did not check Register in any of its forms as I don't know what server to query that returns something which could be registered on.
Summary | ID |
---|---|
9dab83eccabd39a96b050db78cb9e79ee9ccadfd |
Description | From | Last Updated |
---|---|---|
should be != NULL |
grim |
-
-
-
pidgin/plugins/disco/gtkdisco.c (Diff revision 1) Curious why you didn't go with
g_action_map_add_action_entries
Change Summary:
Handle review comments
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+620 -502) |