Modernize XMPP discovery plugin

Review Request #1596 — Created Aug. 15, 2022 and submitted

QuLogic
pidgin/pidgin
default
1598
pidgin

By porting common triggers to actions, dialog buttons to action widgets, GtkMenu to GtkPopoverMenu, using the g_rc_box API, and add braces everywhere. These will mostly make porting to GTK4 easier.

Also, added a default Service name of the JID. Otherwise, looking at xmpp.org, you previously got a big list of empty-looking rows (which also warn when the tooltip is shown).

Opened plugin window, Browsed to xmpp.org and pidgin.im, checked that the Add button opened the Add-to-chat dialog, checked that double-click did the same, checked that the menu item did the same. I did not check Register in any of its forms as I don't know what server to query that returns something which could be registered on.

Summary
Modernize XMPP discovery plugin
Description From Last Updated

should be != NULL

grimgrim
QuLogic
grim
  1. 
      
  2. pidgin/plugins/disco/gtkdisco.c (Diff revision 1)
     
     

    should be != NULL

  3. pidgin/plugins/disco/gtkdisco.c (Diff revision 1)
     
     

    Curious why you didn't go with g_action_map_add_action_entries

    1. Originally, I had only converted the two actions in the menu, and then it seemed less work to do manually. And for GActionEntry, I'd need to fetch them all again, set the startup enabled state (which can't be set in that struct), so I never went back to trying it. But it doesn't look too bad to do now.

    2. cool!

  4. 
      
QuLogic
grim
  1. Ship It!
  2. Great work, thanks!!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...