Summary

The start of the new account editor.

Review Request #1569 — Created Aug. 2, 2022 and submitted Aug. 9, 2022, 3:15 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Right now this just modifies proxy info, and uses some "secret" buttons so that
we don't have to break the existing account editor until this one is finished.

Testing Done

Created a new account using the tau button.
Modified an account using the pi button and verified it's settings matched the old editor.
Modified an account using the old editor and verified that the new editor showed the changes.

Commits

Summary	ID
The start of the new account editor. Right now this just modifies proxy info, and uses some "secret" buttons so that we don't have to break the existing account editor until this one is finished.	a629b967f2d6492c626057fecbbfac986a078e46

Issues

Description	From	Last Updated
Maybe can delete these?	QuLogic	Aug. 9, 2022, 3:13 a.m.
And then this is position 0	QuLogic	Aug. 9, 2022, 3:13 a.m.
Probably also position 0.	QuLogic	Aug. 9, 2022, 3:13 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	The start of the new account editor. Right now this just modifies proxy info, and uses some "secret" buttons so that we don't have to break the existing account editor until this one is finished.	1da1fbee9cc6eae274b3fe770422945edbfac414
	The start of the new account editor. Right now this just modifies proxy info, and uses some "secret" buttons so that we don't have to break the existing account editor until this one is finished.	59e49bd8a17a9667a492df8bbc8253926973ca7f

Diff:

Revision 2 (+994 -16)

Show changes

	pidgin/meson.build
	pidgin/pidginaccounteditor.h
	pidgin/pidginaccounteditor.c
	pidgin/pidginaccountmanager.c
	pidgin/pidginproxyoptions.h
	pidgin/glade/pidgin3.xml.in
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Accounts/editor.ui
	2 more

Ship it!

```
Ship It!
```

Is there going to be more in the notebook?

QuLogic Aug. 9, 2022, 2:57 a.m.

Oh, never mind, I see you said that in the overview...

pidgin/resources/Accounts/editor.ui (Diff revision 2)

Show all issues

Maybe can delete these?

pidgin/resources/Accounts/editor.ui (Diff revision 2)
Show all issues
```
And then this is position 0
```
pidgin/resources/Accounts/editor.ui (Diff revision 2)
Show all issues
```
Probably also position 0.
```

Change Summary:

address issues

Commits:

	Summary	ID
	The start of the new account editor. Right now this just modifies proxy info, and uses some "secret" buttons so that we don't have to break the existing account editor until this one is finished.	59e49bd8a17a9667a492df8bbc8253926973ca7f
	The start of the new account editor. Right now this just modifies proxy info, and uses some "secret" buttons so that we don't have to break the existing account editor until this one is finished.	a629b967f2d6492c626057fecbbfac986a078e46

Diff:

Revision 3 (+970 -16)

Show changes

	pidgin/meson.build
	pidgin/pidginaccounteditor.h
	pidgin/pidginaccounteditor.c
	pidgin/pidginaccountmanager.c
	pidgin/pidginproxyoptions.h
	pidgin/glade/pidgin3.xml.in
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Accounts/editor.ui
	2 more

Review Board 6.0.2

The start of the new account editor.

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)