Summary

Make collapsed groups searchable in the buddy list

Review Request #1494 — Created June 6, 2022 and submitted Oct. 26, 2023, 1:35 a.m.

Information

Owner

belgin

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

PIDGIN-7877

Depends On

Reviewers

Groups

pidgin

People

Description

Searching collapsed groups works by expanding them as they are
traversed by the search function. To mitigate leaving behind
expanded groups that were previously collapsed by the user,
the groups that were expanded by the search are flagged as
such so that they can be collapsed back automatically.

Testing Done

Compiled and tested with lots of groups and buddies on Linux. Also tested with nested buddies.

Commits

Summary	ID
Addressed some issues raised by the reviewers.	69221a31b475ccf2f30c2aceb7dd68f4430d54c4

Issues

Description	From	Last Updated
Just a quick refresher to make sure we're on the same page... The root node of the buddy list is …	grim	Oct. 26, 2023, 1:32 a.m.

The issue has been dropped. Show all issues

Just a quick refresher to make sure we're on the same page...
The root node of the buddy list is a group. it has siblings of other gruops. Each group can contain chats and contacts. Chats have no children but have chats and contacts as siblings. Contacts have chats and contacts as siblings, and buddies as children.
From my understand of this patch, it looks like you are expanding contacts not groups. This would make sense because a GtkTreeModel should already handle searching on hidden/collapsed items.
However, we use a special cell rendered, PidginCellRendererExpander (or something like that). This could actually be inplemented incorrectly and causing search to not find it's children so we might want to look there first, before manually iterating the tree in a function that's alread iterating the tree.
It might worth a proof of concept to see if the native search can find collapsed items.

Status:: Discarded
Change Summary:: belgin stepped away and I don't think anyone else is going to pick this up in the mean time.

Status:

Re-opened

Commits:

	Summary	ID
	Make collapsed groups searchable in the buddy list Searching collapsed groups works by expanding them as they are traversed by the search function. To mitigate leaving behind expanded groups that were previously collapsed by the user, the groups that were expanded by the search are flagged as such so that they can be collapsed back automatically.	7cac7b04dc87f58f929f02f113b876ff187b4a4e
	Addressed some issues raised by the reviewers.	69221a31b475ccf2f30c2aceb7dd68f4430d54c4

Diff:

Revision 2 (+178)

Show changes

pidgin/gtkblist.c

Ship it!

Nice work, thanks for seeing this through to the end!!

Status:: Completed