fix use after free

Review Request #1488 — Created June 2, 2022 and submitted

Information

pidgin/pidgin
release-2.x.y

Reviewers

fix use after free

This fixes an invalid read showing up in valgrind when opening some conversations in Pidgin and the closing Pidgin.
The code was introduced with /r/1342. It looks pretty straightforward so I hope I'm not messing with the fixes that were done in that RR.

Started Pidgin in valgrind, opened some conversations and closed Pidgin again. No more invalid reads are shown.

Summary ID Author
fix use after free
72dfd1327a9bc0e4c7164b43328fe588e5cf3b39 ivanhoe
grim
grim
  1. Ship It!
  2. Great find! Not sure how we missed that during review, but it happens... Thanks a lot!!

  3. 
      
grim
Review request changed
Status:
Completed