Improve XMPP console

Review Request #1476 — Created May 24, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

We can delete some code by switching to PidginAccountChooser and GtkMenuButton. Additionally, prpl-gtalk is gone, so can be dropped.

Compile, opened window, tried toggling XMPP accounts, but there's something wrong with their connection tracking, so it's hard to confirm the chooser reacts correctly. Clicking the toolbar buttons appears to work as before.

Summary ID
Remove unused global in XMPP console
d2549e07e08fbaf50d86b29bcfee3fd1f6525656
Convert XMPP Console into a real templated type
f0aac05e6058f9d5b69f79c645a25eb020673eff
Remove prpl-gtalk from XMPP console
It no longer exists, and complicates the code a bit.
b899f9eba15a7ebef71fad1a85bb9e96e2d6c37a
Use PidginAccountChooser in XMPP console
648e7d502a5fc4b8bbc1c23b4aebb278429aff29
Switch XMPP console to GtkMenuButton
This understands Popover children, and takes care of tracking all the visibility state. It's also Popover-aware enough for GTK4 as well.
c01068319853f8e86811f65fa5b053df1c6fade3
grim
  1. Ship It!
  2. Awesome work, thanks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...