Fix hang when completing a file transfer over XMPP

 






 

 


  Review Request #1466
  —
  Created May 21, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  belgin
 









 
 

  pidgin/pidgin
 









 
 

  release-2.x.y
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
The way purple_xfer_drain_socket was implemented,
if the peer never close()d the connection, we would
wait forever for it to be closed remotely, causing
Pidgin to hang.

 








  


 
 

  
Tested IRC and XMPP on Windows and Linux. Transferred big and small files.

 







 









 





  








 




 







   

    
    
Changes between revision 3 and 4



    

 

 

 

 
orig
1
2
3
4

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Fix hang when completing a file transfer over XMPP
     
The way purple_xfer_drain_socket was implemented,
if the peer never close()d the connection, we would
wait forever for it to be closed remotely, causing
Pidgin to hang.

    

   
  		
  ed91cc38f8f286a116388cf1ae23d7868d304424
  Belgin Știrbu
 


 
  
 
 
  
   
    

     Fix hang when completing a file transfer over XMPP
     
The way purple_xfer_drain_socket was implemented,
if the peer never close()d the connection, we would
wait forever for it to be closed remotely, causing
Pidgin to hang.

Testing Done:
Tested IRC and XMPP on Windows and Linux. Transferred big and small files.

Reviewed at https://reviews.imfreedom.org/r/1466/

    

   
  		
  613b2af77c7a0e32abda71c2bb9eb14942c076f9
  Belgin Știrbu
 




    


    
    

   

  

 









 

  

   
    

     
      
      libpurple/ft.c
     
    

   
  

 










     

    

   

  

  

   
   Loading...