Split VV prefs into a separate widget

Review Request #1459 — Created May 19, 2022 and submitted

QuLogic
pidgin/pidgin
default
pidgin

This is not a strict port of the original code as that used GtkBuilder, while this is now its own widget.

Additionally, moving to HdyPreferencesGroup means the Audio/Video sections are now vertically boxed, but that seems better as it was fairly wide before.

Opened Prefs, changed VV ones a bit to make sure it didn't break. Enabled test pipelines, then switch stacks to make sure they auto-disabled. Unplugged/plugged in a mic to check that the device list re-population did not lose the configured device.

Summary
Split VV prefs into a separate widget
Description From Last Updated

why not use gtk_stack_add_titled which is in gtk4? It takes a name and a title.

grimgrim

Can this be handled with a default handler on the show and hide signals on the vv pref widget?

grimgrim
QuLogic
grim
  1. 
      
  2. pidgin/prefs/pidginprefs.c (Diff revision 2)
     
     

    why not use gtk_stack_add_titled which is in gtk4? It takes a name and a title.

  3. pidgin/prefs/pidginprefs.c (Diff revision 2)
     
     

    Can this be handled with a default handler on the show and hide signals on the vv pref widget?

    1. I don't think the widget actually gets hidden as the gtk_stack_set_visible_child docs say that the child widget has to be visible itself.

  4. 
      
QuLogic
grim
  1. Ship It!
  2. Awesome work, thanks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...