Simplify PidginPrefCombo

Review Request #1451 — Created May 17, 2022 and submitted

QuLogic
pidgin/pidgin
default
pidgin

I'm not sure if GTK got better, or I just overengineered this, but there's a lot of stuff we don't need here.

See individual commit messages for more details of each change.

Opened prefs and checked proxy and VV device combos worked.

Summary
Inline pidgin_prefs_dropdown_from_list_cb
Inline pidgin_prefs_bind_dropdown_from_list_cb
Remove active tracking in PidginPrefsCombo
Drop pref value tracking on PidginPrefsCombo
Inline pidgin_prefs_dropdown_from_list_with_cb
Use GtkListStore for populating VV device prefs
Remove pidgin_prefs_bind_dropdown_from_list
Simplify active iter processing in PidginPrefCombo
Fix leak in PidginPrefCombo
Description From Last Updated

this leaks.

grimgrim

need to free value.

grimgrim

this should be gchar and freed

grimgrim
QuLogic
grim
  1. 
      
  2. pidgin/prefs/pidginprefs.c (Diff revision 2)
     
     

    this leaks.

  3. pidgin/prefs/pidginprefs.c (Diff revision 2)
     
     

    need to free value.

  4. pidgin/prefs/pidginprefs.c (Diff revision 2)
     
     

    this should be gchar and freed

  5. 
      
QuLogic
grim
  1. Ship It!
  2. Awesome work, thank you very much!!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...