Stop including hugo theme in our repo and use hugo modules instead
Review Request #1390 — Created April 24, 2022 and submitted — Latest diff uploaded
To make our site more maintainable this RR attempts to switch from having a complete copy of a theme in our repository and instead use go modules to pull it from it's respective repository.
We have made a few modifications to the original hugo learn theme, some of
which are not easy to split into separate files so for now I'm just including
the files of the learn theme that have our customizations, that way they'll override
the original ones from the theme.Adding
golang
to the Dockerfile since that's needed to be able to use go modules.An important note: This RR was supposed to also include the deletion of the entire
hugo/themes/learn
directory as the idea behind this is that instead of having a full copy of it in our repos, we just pull a specific tag from the upstream repository. Sadly, whenever I try to delete this directory and commit it, I get an error with rbtools when it's trying to validate the commits. I believe this may be due to the amount of files being deleted but I also wasn't able to split the deletion across multiple commits since after 2 different commits rbtools stopped recognizing the 2 oldest ones and just the single newest commit. This is something that we'll need to figure out before merging this, I guess a possibility is always to just agree to have someone do thehg rm
command manually and push it.
Ran
dev-server.sh
and also built the Container image and verified that the site looks the same as it currently does.