Fix leak of buddy icon data

Review Request #1370 — Created March 25, 2022 and submitted March 25, 2022, 7:39 a.m.

Description

All callers of (the internal) purple_buddy_icon_data_new are documented to 'steal' the data for the buddy icon, so the original is leaking.

Testing Done

Ran in valgrind; saw no leaks.

Commits

Summary
	Fix leak of buddy icon data

Screenshots

Issues

Description	From	Last Updated

~		All callers of `purple_buddy_icon_data_new` are documented to 'steal' the data for the buddy icon, so the original is leaking.
	~	All callers of (the internal) `purple_buddy_icon_data_new` are documented to 'steal' the data for the buddy icon, so the original is leaking.

Ship it!

You have a pending review.