-
-
-
pidgin/pidginaccountsdisabledmenu.h (Diff revision 1) Not a
Menu
any more; probably easier to keep the type out of the docs here. -
-
pidgin/pidginaccountsdisabledmenu.c (Diff revision 1) The key doesn't seem to need to be strdup'd, unless that's required of the API?
-
-
pidgin/pidginaccountsdisabledmenu.c (Diff revision 1) I'm no sure if this should be
g_variant_ref_sink
instead. -
Replace PidginAccountsDisabledMenu with PidginInactiveAccountsMenu which is a GMenuModel subclass.
Review Request #1366 — Created March 22, 2022 and submitted
This gives us a bit more control as we are always in control of the attributes, so we don't need to modify the menu in place. This also made it trivial to add the protocol icons which are very helpful when you have the same user name on multiple protocols.
Enabled and disabled two accounts a lot while under valgrind.
Summary | ID |
---|---|
f54207e24fef2f6921106ca24ab72f419b02d28b |
Description | From | Last Updated |
---|---|---|
Should it be disabled? Or maybe inactive? |
QuLogic | |
Not a Menu any more; probably easier to keep the type out of the docs here. |
QuLogic | |
This leaked the existing menu->accounts list. |
QuLogic | |
The key doesn't seem to need to be strdup'd, unless that's required of the API? |
QuLogic | |
Should use the attribute name constants. |
QuLogic | |
I'm no sure if this should be g_variant_ref_sink instead. |
QuLogic | |
Add space. |
QuLogic | |
Update type in comment. |
QuLogic |
Change Summary:
Address issues and rename to PidginInactiveAccountsMenu
Summary: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Commits: |
|
|||||||
Diff: |
Revision 2 (+438 -184) |
Change Summary:
rebased
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+440 -186) |